From 5a9808de5946580422d9437e700933c0280ad1fd Mon Sep 17 00:00:00 2001 From: Azalea <22280294+hykilpikonna@users.noreply.github.com> Date: Sun, 28 Apr 2024 07:48:44 -0400 Subject: [PATCH] [F] Narrow id range to avoid the signed bit in uint32 --- src/main/java/icu/samnyan/aqua/net/UserRegistrar.kt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/icu/samnyan/aqua/net/UserRegistrar.kt b/src/main/java/icu/samnyan/aqua/net/UserRegistrar.kt index 43c21c71..9e30fada 100644 --- a/src/main/java/icu/samnyan/aqua/net/UserRegistrar.kt +++ b/src/main/java/icu/samnyan/aqua/net/UserRegistrar.kt @@ -41,7 +41,10 @@ class UserRegistrar( // We chose 1e9 as the start because normal cards took 0...1e9-1 // This is because games can only take uint32 for card ID, which is at max 10 digits (4294967295) const val cardExtIdStart = 1e9.toLong() - const val cardExtIdEnd = 4294967295 + // Actually, let's not use the UInt32 max but use signed int32 max instead, because Wacca doesn't support uint32 + // const val cardExtIdEnd = 4294967295 + // This range already gives us 1147483647 users, which is more than enough for now + const val cardExtIdEnd = Int.MAX_VALUE.toLong() val log = LoggerFactory.getLogger(UserRegistrar::class.java) }