From 563c426e6e6ff9542b1327a7ca3ced6da6a8cd94 Mon Sep 17 00:00:00 2001
From: leminlimez <59540996+leminlimez@users.noreply.github.com>
Date: Wed, 4 Dec 2024 15:35:59 -0500
Subject: [PATCH] fix update dialog

- fix initializer
- fix exec call
- fix opening link
---
 controllers/web_request_handler.py | 4 ++--
 gui/dialogs.py                     | 6 +++---
 gui/main_window.py                 | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/controllers/web_request_handler.py b/controllers/web_request_handler.py
index ff692e8..79c8a0b 100644
--- a/controllers/web_request_handler.py
+++ b/controllers/web_request_handler.py
@@ -2,7 +2,7 @@ from requests import get, RequestException
 from json import JSONDecodeError
 from devicemanagement.constants import Version
 
-Nugget_Repo_URL = "https://api.github.com/repos/leminlimez/Nugget/releases/latest"
+Nugget_Repo = "leminlimez/Nugget/releases/latest"
 
 last_fetched_version: str = None
 
@@ -23,7 +23,7 @@ def get_latest_version() -> str:
         return last_fetched_version
     # fetch with web requests
     try:
-        response = get(Nugget_Repo_URL)
+        response = get(f"https://api.github.com/repos/{Nugget_Repo}")
         response.raise_for_status()  # To raise an exception for 4xx/5xx responses
 
         data = response.json()  # Parse the JSON response
diff --git a/gui/dialogs.py b/gui/dialogs.py
index 4906e50..a49ca94 100644
--- a/gui/dialogs.py
+++ b/gui/dialogs.py
@@ -3,7 +3,7 @@ from PySide6.QtGui import QFont
 
 from webbrowser import open_new_tab
 
-from controllers.web_request_handler import Nugget_Repo_URL, get_latest_version
+from controllers.web_request_handler import Nugget_Repo, get_latest_version
 
 class GestaltDialog(QDialog):
     def __init__(self, device_manager, gestalt_label, selected_file, parent=None):
@@ -34,7 +34,7 @@ class GestaltDialog(QDialog):
 
 class UpdateAppDialog(QDialog):
     def __init__(self, parent=None):
-        super.__init__(parent)
+        super().__init__(parent)
 
         QBtn = (
             QDialogButtonBox.Ok | QDialogButtonBox.Cancel
@@ -64,5 +64,5 @@ class UpdateAppDialog(QDialog):
 
     def accept(self):
         # open up the repo page
-        open_new_tab(Nugget_Repo_URL)
+        open_new_tab(f"https://github.com/{Nugget_Repo}")
         super().accept()
\ No newline at end of file
diff --git a/gui/main_window.py b/gui/main_window.py
index afc5c73..230df03 100644
--- a/gui/main_window.py
+++ b/gui/main_window.py
@@ -44,7 +44,7 @@ class MainWindow(QtWidgets.QMainWindow):
         # Check for an update
         if is_update_available(App_Version, App_Build):
             # notify with prompt to download the new version from github
-            UpdateAppDialog()
+            UpdateAppDialog().exec()
         # Update the app version/build number label
         self.updateAppVersionLabel()