release: v7.4.0

* feat: add pull input and deprecate pull_strategy

* docs(README): update pull docs

* fix: fix DeepScan issue

* fix: minor formatting change

.all-contributorsrc

@@ -213,6 +213,80 @@
         "doc",
         "code"
       ]
+    },
+    {
+      "login": "rugk",
+      "name": "rugk",
+      "avatar_url": "https://avatars.githubusercontent.com/u/11966684?v=4",
+      "profile": "https://chaos.social/@rugk",
+      "contributions": [
+        "doc"
+      ]
+    },
+    {
+      "login": "xenoterracide",
+      "name": "Caleb Cushing",
+      "avatar_url": "https://avatars.githubusercontent.com/u/5517?v=4",
+      "profile": "https://xenoterracide.com",
+      "contributions": [
+        "bug"
+      ]
+    },
+    {
+      "login": "ruohola",
+      "name": "Eero Ruohola",
+      "avatar_url": "https://avatars.githubusercontent.com/u/33625218?v=4",
+      "profile": "https://ruohola.dev",
+      "contributions": [
+        "bug",
+        "ideas"
+      ]
+    },
+    {
+      "login": "vincentchu12",
+      "name": "Vincent Chu",
+      "avatar_url": "https://avatars.githubusercontent.com/u/23532586?v=4",
+      "profile": "https://github.com/vincentchu12",
+      "contributions": [
+        "bug"
+      ]
+    },
+    {
+      "login": "CWSites",
+      "name": "Matt H",
+      "avatar_url": "https://avatars.githubusercontent.com/u/1242102?v=4",
+      "profile": "https://www.linkedin.com/in/cwsites",
+      "contributions": [
+        "doc",
+        "ideas"
+      ]
+    },
+    {
+      "login": "danielwerg",
+      "name": "danielwerg",
+      "avatar_url": "https://avatars.githubusercontent.com/u/35052399?v=4",
+      "profile": "https://github.com/danielwerg",
+      "contributions": [
+        "doc"
+      ]
+    },
+    {
+      "login": "koppor",
+      "name": "Oliver Kopp",
+      "avatar_url": "https://avatars.githubusercontent.com/u/1366654?v=4",
+      "profile": "https://orcid.org/0000-0001-6962-4290",
+      "contributions": [
+        "ideas"
+      ]
+    },
+    {
+      "login": "Glidias",
+      "name": "Glenn Ko",
+      "avatar_url": "https://avatars.githubusercontent.com/u/190195?v=4",
+      "profile": "https://github.com/Glidias",
+      "contributions": [
+        "ideas"
+      ]
     }
   ],
   "contributorsPerLine": 7,

.eslintrc.js

@@ -4,11 +4,7 @@ module.exports = {
     es6: true,
     node: true
   },
-  extends: [
-    'eslint:recommended',
-    'prettier/@typescript-eslint',
-    'plugin:prettier/recommended'
-  ],
+  extends: ['eslint:recommended', 'plugin:prettier/recommended'],
   globals: {},
   parser: '@typescript-eslint/parser',
   parserOptions: {
@@ -16,10 +12,12 @@ module.exports = {
     sourceType: 'module'
   },
   plugins: ['@typescript-eslint'],
+  ignorePatterns: ['lib/*'],
   rules: {
     'prettier/prettier': 'warn',
     'no-cond-assign': [2, 'except-parens'],
     'no-unused-vars': 0,
+    'no-redeclare': 0,
     '@typescript-eslint/no-unused-vars': 1,
     'no-empty': [
       'error',

.github/FUNDING.yml

@@ -0,0 +1,12 @@
+# These are supported funding model platforms
+
+github: [endbug] # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
+patreon: # Replace with a single Patreon username
+open_collective: # Replace with a single Open Collective username
+ko_fi: # Replace with a single Ko-fi username
+tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
+community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
+liberapay: # Replace with a single Liberapay username
+issuehunt: # Replace with a single IssueHunt username
+otechie: # Replace with a single Otechie username
+custom: # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2']

.github/dependabot.yml

@@ -13,4 +13,4 @@ updates:
       prefix: 'chore'
       include: 'scope'
     labels:
-      - 'type: dependencies'
+      - 'type: chore'

.github/labels.yml

@@ -1,4 +1,3 @@
-# General purpose
 - name: 'good first issue'
   color: '5319e7'
   description: 'Good for newcomers'
@@ -11,70 +10,65 @@
 
 - name: 'status: pending'
   color: c5def5
-  description: 'More info is needed before deciding what to do.'
+  description: 'More info is needed before deciding what to do'
   aliases: []
 
 - name: 'status: pinned'
   color: 0052cc
-  description: 'Issues and PRs that should not be labeled as stale or closed if they remain inactive.'
+  description: 'Should not be labeled as stale'
   aliases: []
 
 - name: 'status: stale'
   color: fbca04
-  description: 'Inactive issues and PRs.'
+  description: 'Inactive issues and PRs'
   aliases: ['stale']
 
 - name: 'status: wontfix'
-  color: ffffff
-  description: 'This will not be worked on.'
+  color: cfd3d7
+  description: 'This will not be worked on'
   aliases: ['wontfix']
 
-- name: 'type: automation'
-  color: 2fc904
-  description: 'About actions workflows and automation.'
-  aliases: ['automation', 'actions']
-
 - name: 'type: bug'
   color: d73a4a
-  description: 'Verified problems that need to be worked on.'
+  description: 'Verified problems that need to be worked on'
   aliases: ['bug']
 
-- name: 'type: dependencies'
-  color: 0366d6
-  description: 'Pull requests that update a dependency file'
-  aliases: ['dependencies']
+- name: 'type: chore'
+  color: C5DEF5
+  description: 'Code changes that neither fix bugs nor add features (refactoring, dependency chnages, ...)'
+  aliases: ['dependencies', 'type: dependencies', 'automation', 'type: automation']
+
+- name: 'type: docs'
+  color: C5DEF5
+  description: "Documentation changes"
+  aliases: ['documentation', 'maintenance', 'type: maintenance']
 
 - name: 'type: duplicate'
   color: cfd3d7
-  description: 'This issue or pull request already exists.'
+  description: 'This issue or pull request already exists'
   aliases: ['duplicate']
 
-- name: 'type: enhancement'
-  color: a2eeef
-  description: 'New feature or request.'
-  aliases: ['enhancement']
+- name: 'type: feature'
+  color: 0E8A16
+  description: 'New feature or feature request'
+  aliases: ['enhancement', 'type: enhancement']
+
+- name: 'type: fix'
+  color: 1D76DB
+  description: 'Updates to existing functionalities'
+  aliases: ['fix']
 
 - name: 'type: invalid'
   color: e4e669
-  description: "This doesn't seem right."
+  description: "This doesn't seem right"
   aliases: ['invalid']
 
-- name: 'type: maintenance'
-  color: 0075ca
-  description: "Documentation improvements and code refactoring, doesn't affect functionality."
-  aliases: ['documentation', 'docs']
-
 - name: 'type: not a bug'
   color: 0e8a16
-  description: 'Reports that happen not be our fault.'
+  description: 'Reports that happen not be our fault'
   aliases: ['not a bug']
 
 - name: 'type: question'
   color: d876e3
-  description: 'Further information is requested.'
+  description: 'Further information is requested'
   aliases: ['question']
-
-- name: 'type: security'
-  color: 'ee0701'
-  description: 'Pull requests that address a security vulnerability.'
-  aliases: ['security']

.github/stale.yml

@@ -0,0 +1,19 @@
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 20
+# Number of days of inactivity before a stale issue is closed
+daysUntilClose: 5
+# Issues with these labels will never be considered stale
+exemptLabels:
+  - pinned
+  - security
+  - 'status: pinned'
+  - 'type: security'
+# Label to use when marking an issue as stale
+staleLabel: 'status: stale'
+# Comment to post when marking an issue as stale. Set to `false` to disable
+markComment: >
+  This issue has been automatically marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs. Thank you
+  for your contributions.
+# Comment to post when closing a stale issue. Set to `false` to disable
+closeComment: false

.github/workflows/stale.yml

@@ -1,21 +0,0 @@
-name: 'Handle stale issues and PRs'
-on:
-  schedule:
-    - cron: '0 0 * * *'
-  workflow_dispatch:
-
-jobs:
-  stale:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/stale@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          stale-issue-message: 'This issue is being marked as "stale" because it has been open 20 days with no activity. Remove the "stale" label or comment, otherwise this will be closed in 5 days.'
-          stale-issue-label: 'status: stale'
-          exempt-issue-labels: 'status: pinned'
-          stale-pr-message: 'This PR is being marked as "stale" because it has been open 20 days with no activity. Remove the "stale" label or comment, otherwise this will be closed in 5 days.'
-          stale-pr-label: 'status: stale'
-          exempt-pr-labels: 'status: pinned'
-          days-before-stale: 20
-          days-before-close: 5

.husky/.gitignore

@@ -0,0 +1 @@
+_

.husky/pre-commit

@@ -0,0 +1,5 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+npm run build
+git add lib

CHANGELOG.md

@@ -7,6 +7,59 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [7.4.0] - 2021-09-30
+
+### Added:
+
+- Added `pull` input: you can use it to change the arguments of the `git pull` command (#294)
+
+### Changed:
+
+- Deprecated `pull_strategy`: use `pull` instead (#294)
+
+## [7.3.0] - 2021-09-06
+
+### Added:
+
+- Added custom committer support via the `committer_name` and `committer_email` inputs (#264)
+- Added `commit_sha` output (#275)
+- Added `pathspec_error_handling` input (#280)
+
+## [7.2.1] - 2021-05-11
+
+### Fixed:
+
+- Fixed an issue with missing outputs (#189)
+
+## [7.2.0] - 2021-04-22
+
+### Added:
+
+- `default_author`: this input allows you to control how the action fills missing author name or email (issue #167)
+- `github_token` input introduced to get token to use in API calls
+
+### Fixed:
+
+- Git args are now parsed with [`string-argv`](https://npm.im/string-argv), the format has to comply with what the package can parse (issue #179)
+
+## [7.1.2] - 2021-04-16
+
+### Fixed:
+
+- Git args parsing now correctly handles quotes, that can be used for multi-word arguments (issue #166)
+
+## [7.1.1] - 2021-04-04
+
+### Fixed:
+
+- Git args parsing has been improved, and now handles spaces correctly (issue #154)
+
+## [7.1.0] - 2021-03-03
+
+### Added:
+
+- `pull_strategy`: you can use 'NO-PULL' to prevent the action from pulling from the remote at all.
+
 ## [7.0.0] - 2021-01-16
 
 ### Changed:
@@ -213,7 +266,7 @@ First release
 
 #
 
-[unreleased]: https://github.com/EndBug/add-and-commit/compare/v7.0.0...HEAD
+[unreleased]: https://github.com/EndBug/add-and-commit/compare/v7.4.0...HEAD
 [1.0.0]: https://github.com/EndBug/add-and-commit/tree/v1.0.0
 [2.0.0]: https://github.com/EndBug/add-and-commit/compare/v1.0.0...v2.0.0
 [2.1.0]: https://github.com/EndBug/add-and-commit/compare/v2.0.0...v2.1.0
@@ -243,3 +296,10 @@ First release
 [6.1.0]: https://github.com/EndBug/add-and-commit/compare/v6.0.0...v6.1.0
 [6.2.0]: https://github.com/EndBug/add-and-commit/compare/v6.1.0...v6.2.0
 [7.0.0]: https://github.com/EndBug/add-and-commit/compare/v6.2.0...v7.0.0
+[7.1.0]: https://github.com/EndBug/add-and-commit/compare/v7.0.0...v7.1.0
+[7.1.1]: https://github.com/EndBug/add-and-commit/compare/v7.1.0...v7.1.1
+[7.1.2]: https://github.com/EndBug/add-and-commit/compare/v7.1.1...v7.1.2
+[7.2.0]: https://github.com/EndBug/add-and-commit/compare/v7.1.2...v7.2.0
+[7.2.1]: https://github.com/EndBug/add-and-commit/compare/v7.2.0...v7.2.1
+[7.3.0]: https://github.com/EndBug/add-and-commit/compare/v7.2.1...v7.3.0
+[7.4.0]: https://github.com/EndBug/add-and-commit/compare/v7.3.0...v7.4.0

README.md

@@ -1,6 +1,6 @@
 # Add & Commit
 
-[![Public workflows that use this action.](https://img.shields.io/endpoint?url=https%3A%2F%2Fapi-git-master.endbug.vercel.app%2Fapi%2Fgithub-actions%2Fused-by%3Faction%3DEndBug%2Fadd-and-commit%26badge%3Dtrue)](https://github.com/search?o=desc&q=EndBug+add-and-commit+path%3A.github%2Fworkflows+language%3AYAML&s=&type=Code)
+[![Public workflows that use this action.](https://img.shields.io/endpoint?url=https%3A%2F%2Fapi-endbug.vercel.app%2Fapi%2Fgithub-actions%2Fused-by%3Faction%3DEndBug%2Fadd-and-commit%26badge%3Dtrue)](https://github.com/search?o=desc&q=EndBug+add-and-commit+path%3A.github%2Fworkflows+language%3AYAML&s=&type=Code)
 [![All Contributors](https://img.shields.io/github/all-contributors/EndBug/add-and-commit)](#contributors-)
 
 You can use this GitHub Action to commit changes made in your workflow run directly to your repo: for example, you use it to lint your code, update documentation, commit updated builds, etc....
@@ -8,40 +8,62 @@ You can use this GitHub Action to commit changes made in your workflow run direc
 This is **heavily** inspired by [git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) (by [Stefan Zweifel](https://github.com/stefanzweifel)): that action automatically detects changed files and commits them. While this is useful for most situations, this doesn't commit untracked files and can sometimes commit unintended changes (such as `package-lock.json` or similar, that may have happened during previous steps).  
 This action lets you choose the path that you want to use when adding & committing changes so that it works as you would normally do using `git` on your machine.
 
-## Usage
+## Inputs
 
 Add a step like this to your workflow:
 
 ```yaml
-- uses: EndBug/add-and-commit@v7 # You can change this to use a specific version
+- uses: EndBug/add-and-commit@v7 # You can change this to use a specific version.
   with:
     # The arguments for the `git add` command (see the paragraph below for more info)
     # Default: '.'
     add: 'src'
 
-    # The name of the user that will be displayed as the author of the commit
-    # Default: author of the commit that triggered the run
-    author_name: Your Name
+    # The name of the user that will be displayed as the author of the commit.
+    # Default: depends on the default_author input
+    author_name: Author Name
 
-    # The email of the user that will be displayed as the author of the commit
-    # Default: author of the commit that triggered the run
+    # The email of the user that will be displayed as the author of the commit.
+    # Default: depends on the default_author input
     author_email: mail@example.com
 
-    # Name of the branch to use, if different from the one that triggered the workflow
+    # The name of the branch to use, if different from the one that triggered the workflow.
     # Default: the branch that triggered the run
     branch: some-branch
 
-    # The local path to the directory where your repository is located. You should use actions/checkout first to set it up
+    # The name of the custom committer you want to use, if different from the author of the commit.
+    # Default: the name of the author (set with either author_name or default_author)
+    committer_name: Committer Name
+
+    # The email of the custom committer you want to use, if different from the author of the commit.
+    # Default: the email of the author (set with either author_email or default_author)
+    committer_email: mail@example.com
+
+    # The local path to the directory where your repository is located. You should use actions/checkout first to set it up.
     # Default: '.'
     cwd: './path/to/the/repo'
 
-    # The message for the commit
+    # Determines the way the action fills missing author name and email. Three options are available:
+    # - github_actor -> UserName <UserName@users.noreply.github.com>
+    # - user_info -> Your Display Name <your-actual@email.com>
+    # - github_actions -> github-actions <email associated with the github logo>
+    # Default: github_actor
+    default_author: github_actor
+
+    # The message for the commit.
     # Default: 'Commit from GitHub Actions (name of the workflow)'
     message: 'Your commit message'
 
-    # The flag used on the pull strategy
+    # The way the action should handle pathspec errors from the add and remove commands. Three options are available:
+    # - ignore -> errors will be logged but the step won't fail
+    # - exitImmediately -> the action will stop right away, and the step will fail
+    # - exitAtEnd -> the action will go on, every pathspec error will be logged at the end, the step will fail.
+    # Default: ignore
+    pathspec_error_handling: ignore
+
+    # Arguments for the git pull command. Use NO-PULL to avoid the action pulling at all.
     # Default: '--no-rebase'
-    pull_strategy: '--no-rebase or --no-ff or --rebase'
+    pull: 'NO-PULL or --rebase --autostash ...'
 
     # Whether to push the commit and, if any, its tags to the repo. It can also be used to set the git push arguments (see the paragraph below for more info)
     # Default: true
@@ -51,7 +73,7 @@ Add a step like this to your workflow:
     # Default: ''
     remove: './dir/old_file.js'
 
-    # Whether to use the --signoff option on `git commit` (only `true` and `false` are accepted)
+    # Whether to use the --signoff option on `git commit` (only boolean values accepted*)
     # Default: false
     signoff: true
 
@@ -60,19 +82,24 @@ Add a step like this to your workflow:
     tag: 'v1.0.0 --force'
 ```
 
-### Adding files:
+### Git arguments
+
+Multiple options let you provide the git arguments that you want the action to use. It's important to note that these arguments **are not actually used with a CLI command**, but they are parsed by a package called [`string-argv`](https://npm.im/string-argv), and then used with [`simple-git`](https://npm.im/simple-git).  
+What does this mean for you? It means that string that contain a lot of nested quotes may be parsed incorrectly, and that specific ways of declaring arguments may not be supported by this libraries. If you're having issues with your argument strings you can check whether they're being parsed correctly either by [enabling debug logging](https://docs.github.com/en/actions/managing-workflow-runs/enabling-debug-logging) for your workflow runs or by testing it directly with `string-argv` ([RunKit demo](https://npm.runkit.com/string-argv)): if each argument and option is aprsed correctly you'll see an array where every string is an option or value.
+
+### Adding files
 
 The action adds files using a regular `git add` command, so you can put every kind of argument in the `add` option. For example, if you want to force-add a file: `./path/to/file.txt --force`.  
-The script will not stop if one of the git commands fails. E.g.: if your command shows a "fatal: pathspec 'yourFile' did not match any files" error the action will go on.  
+The script will not stop if one of the git commands doesn't match any file. E.g.: if your command shows a "fatal: pathspec 'yourFile' did not match any files" error the action will go on.  
 You can also use JSON or YAML arrays (e.g. `'["first", "second"]'`, `"['first', 'second']"`) to make the action run multiple `git add` commands: the action will log how your input has been parsed. Please mind that your input still needs to be a string because of how GitHub Actions works with inputs: just write your array inside the string, the action will parse it later.
 
-### Deleting files:
+### Deleting files
 
 You can delete files with the `remove` option: that runs a `git rm` command that will stage the files in the given path for removal. As with the `add` argument, you can use every option `git rm` allows (e.g. add `--force` to ignore `.gitignore` rules).  
-The script will not stop if one of the git commands fails. E.g.: if your command shows a "fatal: pathspec 'yourFile' did not match any files" error the action will go on.  
+The script will not stop if one of the git commands doesn't match any file. E.g.: if your command shows a "fatal: pathspec 'yourFile' did not match any files" error the action will go on.  
 You can also use JSON or YAML arrays (e.g. `'["first", "second"]'`, `"['first', 'second']"`) to make the action run multiple `git rm` commands: the action will log how your input has been parsed. Please mind that your input still needs to be a string because of how GitHub Actions works with inputs: just write your array inside the string, the action will parse it later.
 
-### Pushing:
+### Pushing
 
 By default the action runs the following command: `git push origin ${branch input} --set-upstream`. You can use the `push` input to modify this behavior, here's what you can set it to:
 
@@ -83,26 +110,77 @@ By default the action runs the following command: `git push origin ${branch inpu
 
 One way to use this is if you want to force push to a branch of your repo: you'll need to set the `push` input to, for example, `origin yourBranch --force`.
 
-### Tagging:
+### Tagging
 
 You can use the `tag` option to enter the arguments for a `git add` command. In order for the action to isolate the tag name from the rest of the arguments, it should be the first word not preceded by an hyphen (e.g. `-a tag-name -m "some other stuff"` is ok).
 
-### Tokens:
+### Tokens
 
 When pushing, the action uses the token that the local git repository has been configured with: that means that if you want to change it you'll need to do it in the steps that run before this action. For example: if you set up your repo with [`actions/checkout`](https://github.com/actions/checkout/) then you have to add the token there.  
 Changing the token with which the repo is configured can be useful if you want to run CI checks on the commit pushed by this action; anyway, it has to be set up outside of this action.
 
-### Outputs:
+The action automatically gets the GitHub token from a `github_token` input: this input should not be modified by the user, since it doesn't affect the commits as it's only used to access the GitHub API to get user info, in case they selected that option for the commit author.
+
+### About `actions/checkout`
+
+The token you use when setting up the repo with this action will determine what token `add-and-commit` will use.  
+Some users reported that they were getting an error:
+
+```
+> fatal: could not read Username for 'https://github.com': No such device or address
+```
+
+If you're getting this error and you're using `actions/checkout@v1`, try upgrading to `actions/checkout@v2`. If you're still having problems after upgrading, feel free to open an issue. Issue ref: [#146](https://github.com/EndBug/add-and-commit/issues/146)
+
+## Outputs
 
 The action provides these outputs:
 
 - `committed`: whether the action has created a commit (`'true'` or `'false'`)
-- `pushed`: whether the action has pushed to teh remote(`'true'` or `'false'`)
+- `commit_sha`: the short 7-digit sha of the commit that has just been created
+- `pushed`: whether the action has pushed to the remote (`'true'` or `'false'`)
 - `tagged`: whether the action has created a tag (`'true'` or `'false'`)
 
 For more info on how to use outputs, see ["Context and expression syntax"](https://docs.github.com/en/free-pro-team@latest/actions/reference/context-and-expression-syntax-for-github-actions).
 
-### Examples:
+## Examples
+
+If you don't want to use your GitHub username for the CI commits, you can use the `default_author` option to make it appear as if it was made by "github-actions"
+
+<img src="https://user-images.githubusercontent.com/26386270/115738624-80b51780-a38d-11eb-9bbe-77461654274c.png" height=40/>
+
+```yaml
+on: push
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: EndBug/add-and-commit@v7
+        with:
+          default_author: github_actions
+```
+
+You can also use the `committer_name` and `committer_email` inputs to make it appear as if GitHub Actions is the committer, here are a couple of example steps:
+
+<img src="https://user-images.githubusercontent.com/26386270/130594168-1d910710-e2d0-4b06-9324-cbe5dde59154.png" height=70/>
+
+```yaml
+- uses: EndBug/add-and-commit@v7
+  with:
+    message: Show GitHub Actions logo
+    committer_name: GitHub Actions
+    committer_email: actions@github.com
+```
+
+<img src="https://user-images.githubusercontent.com/26386270/130594443-b881fae7-3064-4020-a4cc-6db37ef0df65.png" height=70/>
+
+```yaml
+- uses: EndBug/add-and-commit@v7
+  with:
+    message: Show GitHub logo
+    committer_name: GitHub Actions
+    committer_email: 41898282+github-actions[bot]@users.noreply.github.com
+```
 
 Do you want to lint your JavaScript files, located in the `src` folder, with ESLint, so that fixable changes are done without your intervention? You can use a workflow like this:
 
@@ -203,6 +281,16 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
   </tr>
   <tr>
     <td align="center"><a href="https://dominikschilling.de"><img src="https://avatars2.githubusercontent.com/u/617637?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Dominik Schilling</b></sub></a><br /><a href="#ideas-ocean90" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/EndBug/add-and-commit/commits?author=ocean90" title="Documentation">📖</a> <a href="https://github.com/EndBug/add-and-commit/commits?author=ocean90" title="Code">💻</a></td>
+    <td align="center"><a href="https://chaos.social/@rugk"><img src="https://avatars.githubusercontent.com/u/11966684?v=4?s=100" width="100px;" alt=""/><br /><sub><b>rugk</b></sub></a><br /><a href="https://github.com/EndBug/add-and-commit/commits?author=rugk" title="Documentation">📖</a></td>
+    <td align="center"><a href="https://xenoterracide.com"><img src="https://avatars.githubusercontent.com/u/5517?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Caleb Cushing</b></sub></a><br /><a href="https://github.com/EndBug/add-and-commit/issues?q=author%3Axenoterracide" title="Bug reports">🐛</a></td>
+    <td align="center"><a href="https://ruohola.dev"><img src="https://avatars.githubusercontent.com/u/33625218?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Eero Ruohola</b></sub></a><br /><a href="https://github.com/EndBug/add-and-commit/issues?q=author%3Aruohola" title="Bug reports">🐛</a> <a href="#ideas-ruohola" title="Ideas, Planning, & Feedback">🤔</a></td>
+    <td align="center"><a href="https://github.com/vincentchu12"><img src="https://avatars.githubusercontent.com/u/23532586?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Vincent Chu</b></sub></a><br /><a href="https://github.com/EndBug/add-and-commit/issues?q=author%3Avincentchu12" title="Bug reports">🐛</a></td>
+    <td align="center"><a href="https://www.linkedin.com/in/cwsites"><img src="https://avatars.githubusercontent.com/u/1242102?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Matt H</b></sub></a><br /><a href="https://github.com/EndBug/add-and-commit/commits?author=CWSites" title="Documentation">📖</a> <a href="#ideas-CWSites" title="Ideas, Planning, & Feedback">🤔</a></td>
+    <td align="center"><a href="https://github.com/danielwerg"><img src="https://avatars.githubusercontent.com/u/35052399?v=4?s=100" width="100px;" alt=""/><br /><sub><b>danielwerg</b></sub></a><br /><a href="https://github.com/EndBug/add-and-commit/commits?author=danielwerg" title="Documentation">📖</a></td>
+  </tr>
+  <tr>
+    <td align="center"><a href="https://orcid.org/0000-0001-6962-4290"><img src="https://avatars.githubusercontent.com/u/1366654?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Oliver Kopp</b></sub></a><br /><a href="#ideas-koppor" title="Ideas, Planning, & Feedback">🤔</a></td>
+    <td align="center"><a href="https://github.com/Glidias"><img src="https://avatars.githubusercontent.com/u/190195?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Glenn Ko</b></sub></a><br /><a href="#ideas-Glidias" title="Ideas, Planning, & Feedback">🤔</a></td>
   </tr>
 </table>
 

action.yml

@@ -9,25 +9,42 @@ inputs:
   author_name:
     description: The name of the user that will be displayed as the author of the commit
     required: false
-    default: ${{ github.actor }}
   author_email:
     description: The email of the user that will be displayed as the author of the commit
     required: false
-    default: ${{ github.actor }}@users.noreply.github.com
   branch:
     description: Name of the branch to use, if different from the one that triggered the workflow
     required: false
+  committer_name:
+    description: The name of the custom committer you want to use
+    required: false 
+  committer_email:
+    description: The email of the custom committer you want to use
+    required: false
   cwd:
     description: The directory where your repository is located. You should use actions/checkout first to set it up
     required: false
     default: '.'
+  default_author:
+    description: How the action should fill missing author name or email.
+    required: false
+    default: 'github_actor'
   message:
     description: The message for the commit
     required: false
-  pull_strategy:
-    description: The flag used on the pull strategy
+  pathspec_error_handling:
+    description: The way the action should handle pathspec errors from the add and remove commands.
     required: false
-    default: '--no-rebase'
+    default: ignore
+  pull:
+    description: Arguments for the git pull command. Use NO-PULL to avoid the action pulling at all.
+    required: false
+    # Default value currently set in runtime
+    # default: '--no-rebase'
+  pull_strategy:
+    description: The flag used on the pull strategy. Use NO-PULL to avoid the action pulling at all.
+    required: false
+    deprecationMessage: The 'pull_strategy' input is deprecated, please use 'pull'
   push:
     description: Whether to push the commit and, if any, its tags to the repo. It can also be used to set the git push arguments (more info in the README)
     required: false
@@ -41,10 +58,18 @@ inputs:
   tag:
     description: Arguments for the git tag command (the tag name always needs to be the first word not preceded by a hyphen)
     required: false
+    
+  # Input not required from the user
+  github_token:
+    description: The token used to make requests to the GitHub API. It's NOT used to make commits and should not be changed.
+    required: false
+    default: ${{ github.token }}
 
 outputs:
   committed:
     description: Whether the action has created a commit.
+  commit_sha:
+    description: The SHA of the commit that has been created.
   pushed:
     description: Whether the action has pushed to the remote.
   tagged:

package.json

@@ -1,6 +1,7 @@
 {
   "name": "add-and-commit",
-  "version": "7.0.0",
+  "version": "7.4.0",
+  "private": true,
   "description": "Add & commit files from a path directly from GitHub Actions",
   "main": "lib/index.js",
   "scripts": {
@@ -9,13 +10,9 @@
     "lint": "eslint --ext .ts src",
     "lint:fix": "eslint --ext .ts --fix src",
     "changelog": "ts-node scripts/changelog.ts && npm i",
+    "prepare": "husky install",
     "test": "echo \"Error: no test specified\" && exit 1"
   },
-  "husky": {
-    "hooks": {
-      "pre-commit": "npm run build && git add lib"
-    }
-  },
   "repository": {
     "type": "git",
     "url": "git+https://github.com/EndBug/add-and-commit.git"
@@ -34,24 +31,26 @@
   },
   "homepage": "https://github.com/EndBug/add-and-commit#readme",
   "dependencies": {
-    "@actions/core": "^1.2.6",
-    "js-yaml": "^4.0.0",
-    "simple-git": "^2.27.0"
+    "@actions/core": "^1.5.0",
+    "actions-toolkit": "github:EndBug/actions-toolkit#core-actions",
+    "js-yaml": "^4.1.0",
+    "simple-git": "^2.27.0",
+    "string-argv": "^0.3.1"
   },
   "devDependencies": {
-    "@types/js-yaml": "^4.0.0",
+    "@types/js-yaml": "^4.0.3",
     "@types/node": "^12.12.54",
-    "@typescript-eslint/eslint-plugin": "^2.34.0",
-    "@typescript-eslint/parser": "^2.34.0",
-    "@vercel/ncc": "^0.26.2",
-    "all-contributors-cli": "^6.19.0",
-    "eslint": "^6.8.0",
-    "eslint-config-prettier": "^6.15.0",
-    "eslint-plugin-prettier": "^3.3.1",
-    "husky": "^4.3.7",
-    "prettier": "^2.2.1",
-    "ts-node": "^9.1.1",
-    "typescript": "^4.1.3",
+    "@typescript-eslint/eslint-plugin": "^4.31.2",
+    "@typescript-eslint/parser": "^4.32.0",
+    "@vercel/ncc": "^0.31.1",
+    "all-contributors-cli": "^6.20.0",
+    "eslint": "^7.32.0",
+    "eslint-config-prettier": "^8.3.0",
+    "eslint-plugin-prettier": "^4.0.0",
+    "husky": "^7.0.2",
+    "prettier": "^2.4.1",
+    "ts-node": "^10.2.1",
+    "typescript": "^4.4.3",
     "yamljs": "^0.3.0"
   }
 }

src/main.ts

@@ -1,93 +1,106 @@
-import {
-  info,
-  setFailed,
-  warning,
-  debug,
-  startGroup,
-  endGroup
-} from '@actions/core'
+import * as core from '@actions/core'
 import path from 'path'
-import simpleGit, { Response } from 'simple-git'
+import simpleGit, { CommitSummary, Response } from 'simple-git'
 import YAML from 'js-yaml'
-import { getInput, Input, log, outputs, parseBool, setOutput } from './util'
+import {
+  getInput,
+  getUserInfo,
+  input,
+  log,
+  matchGitArgs,
+  outputs,
+  readJSON,
+  setOutput
+} from './util'
 
 const baseDir = path.join(process.cwd(), getInput('cwd') || '')
 const git = simpleGit({ baseDir })
-console.log(`Running in ${baseDir}`)
-;(async () => {
-  await checkInputs().catch(setFailed)
 
-  startGroup('Internal logs')
-  info('> Staging files...')
+const exitErrors: Error[] = []
+
+core.info(`Running in ${baseDir}`)
+;(async () => {
+  await checkInputs().catch(core.setFailed)
+
+  core.startGroup('Internal logs')
+  core.info('> Staging files...')
+
+  const peh = getInput('pathspec_error_handling')
 
   if (getInput('add')) {
-    info('> Adding files...')
-    await add()
-  } else info('> No files to add.')
+    core.info('> Adding files...')
+    await add(peh == 'ignore' ? 'pathspec' : 'none')
+  } else core.info('> No files to add.')
 
   if (getInput('remove')) {
-    info('> Removing files...')
-    await remove()
-  } else info('> No files to remove.')
+    core.info('> Removing files...')
+    await remove(peh == 'ignore' ? 'pathspec' : 'none')
+  } else core.info('> No files to remove.')
 
-  info('> Checking for uncommitted changes in the git working tree...')
+  core.info('> Checking for uncommitted changes in the git working tree...')
   const changedFiles = (await git.diffSummary(['--cached'])).files.length
   if (changedFiles > 0) {
-    info(`> Found ${changedFiles} changed files.`)
+    core.info(`> Found ${changedFiles} changed files.`)
 
     await git
       .addConfig('user.email', getInput('author_email'), undefined, log)
       .addConfig('user.name', getInput('author_name'), undefined, log)
-    debug(
+      .addConfig('author.email', getInput('author_email'), undefined, log)
+      .addConfig('author.name', getInput('author_name'), undefined, log)
+      .addConfig('committer.email', getInput('committer_email'), undefined, log)
+      .addConfig('committer.name', getInput('committer_name'), undefined, log)
+    core.debug(
       '> Current git config\n' +
         JSON.stringify((await git.listConfig()).all, null, 2)
     )
 
     await git.fetch(['--tags', '--force'], log)
 
-    info('> Switching/creating branch...')
+    core.info('> Switching/creating branch...')
     await git
       .checkout(getInput('branch'), undefined, log)
       .catch(() => git.checkoutLocalBranch(getInput('branch'), log))
 
-    info('> Pulling from remote...')
-    await git.fetch(undefined, log).pull(
-      undefined,
-      undefined,
-      {
-        [getInput('pull_strategy')]: null
-      },
-      log
-    )
+    // The current default value is set here.
+    // When the depreacted pull_strategy input is removed, the default should be set via the action manifest.
+    const pull = getInput('pull') || getInput('pull_strategy') || '--no-rebase'
+    if (pull == 'NO-PULL') core.info('> Not pulling from repo.')
+    else {
+      core.info('> Pulling from remote...')
+      core.debug(`Current git pull arguments: ${pull}`)
+      await git
+        .fetch(undefined, log)
+        .pull(undefined, undefined, matchGitArgs(pull), log)
+    }
 
-    info('> Re-staging files...')
-    if (getInput('add')) await add({ ignoreErrors: true })
-    if (getInput('remove')) await remove({ ignoreErrors: true })
+    core.info('> Re-staging files...')
+    if (getInput('add')) await add('all')
+    if (getInput('remove')) await remove('all')
 
-    info('> Creating commit...')
+    core.info('> Creating commit...')
     await git.commit(
       getInput('message'),
       undefined,
       {
-        '--author': `"${getInput('author_name')} <${getInput(
-          'author_email'
-        )}>"`,
         ...(getInput('signoff')
           ? {
               '--signoff': null
             }
           : {})
       },
-      (err, data?) => {
-        if (data) setOutput('committed', 'true')
+      (err, data?: CommitSummary) => {
+        if (data) {
+          setOutput('committed', 'true')
+          setOutput('commit_sha', data.commit)
+        }
         return log(err, data)
       }
     )
 
     if (getInput('tag')) {
-      info('> Tagging commit...')
+      core.info('> Tagging commit...')
       await git
-        .tag(getInput('tag').split(' '), (err, data?) => {
+        .tag(matchGitArgs(getInput('tag') || ''), (err, data?) => {
           if (data) setOutput('tagged', 'true')
           return log(err, data)
         })
@@ -95,16 +108,23 @@ console.log(`Running in ${baseDir}`)
           setOutput('tagged', 'true')
           return log(null, data)
         })
-        .catch((err) => setFailed(err))
-    } else info('> No tag info provided.')
+        .catch((err) => core.setFailed(err))
+    } else core.info('> No tag info provided.')
 
-    const pushOption = parseBool(getInput('push')) ?? getInput('push')
+    let pushOption: string | boolean
+    try {
+      pushOption = getInput('push', true)
+    } catch {
+      pushOption = getInput('push')
+    }
     if (pushOption) {
       // If the options is `true | string`...
-      info('> Pushing commit to repo...')
+      core.info('> Pushing commit to repo...')
 
       if (pushOption === true) {
-        debug(`Running: git push origin ${getInput('branch')} --set-upstream`)
+        core.debug(
+          `Running: git push origin ${getInput('branch')} --set-upstream`
+        )
         await git.push(
           'origin',
           getInput('branch'),
@@ -115,11 +135,11 @@ console.log(`Running in ${baseDir}`)
           }
         )
       } else {
-        debug(`Running: git push ${pushOption}`)
+        core.debug(`Running: git push ${pushOption}`)
         await git.push(
           undefined,
           undefined,
-          pushOption.split(' '),
+          matchGitArgs(pushOption),
           (err, data?) => {
             if (data) setOutput('pushed', 'true')
             return log(err, data)
@@ -128,11 +148,13 @@ console.log(`Running in ${baseDir}`)
       }
 
       if (getInput('tag')) {
-        info('> Pushing tags to repo...')
+        core.info('> Pushing tags to repo...')
         await git
           .pushTags('origin', undefined, (e, d?) => log(undefined, e || d))
           .catch(() => {
-            info('> Tag push failed: deleting remote tag and re-pushing...')
+            core.info(
+              '> Tag push failed: deleting remote tag and re-pushing...'
+            )
             return git
               .push(
                 undefined,
@@ -140,44 +162,53 @@ console.log(`Running in ${baseDir}`)
                 {
                   '--delete': null,
                   origin: null,
-                  [getInput('tag')
-                    .split(' ')
-                    .filter((w) => !w.startsWith('-'))[0]]: null
+                  [matchGitArgs(getInput('tag') || '').filter(
+                    (w) => !w.startsWith('-')
+                  )[0]]: null
                 },
                 log
               )
               .pushTags('origin', undefined, log)
           })
-      } else info('> No tags to push.')
-    } else info('> Not pushing anything.')
+      } else core.info('> No tags to push.')
+    } else core.info('> Not pushing anything.')
 
-    endGroup()
-    info('> Task completed.')
+    core.endGroup()
+    core.info('> Task completed.')
   } else {
-    endGroup()
-    info('> Working tree clean. Nothing to commit.')
+    core.endGroup()
+    core.info('> Working tree clean. Nothing to commit.')
   }
 })()
+  .then(() => {
+    // Check for exit errors
+    if (exitErrors.length == 1) throw exitErrors[0]
+    else if (exitErrors.length > 1) {
+      exitErrors.forEach((e) => core.error(e))
+      throw 'There have been multiple runtime errors.'
+    }
+  })
   .then(logOutputs)
   .catch((e) => {
-    endGroup()
+    core.endGroup()
     logOutputs()
-    setFailed(e)
+    core.setFailed(e)
   })
 
 async function checkInputs() {
-  function setInput(input: Input, value: string | undefined) {
+  function setInput(input: input, value: string | undefined) {
     if (value) return (process.env[`INPUT_${input.toUpperCase()}`] = value)
     else return delete process.env[`INPUT_${input.toUpperCase()}`]
   }
-  function setDefault(input: Input, value: string) {
+  function setDefault(input: input, value: string) {
     if (!getInput(input)) setInput(input, value)
     return getInput(input)
   }
 
   const eventPath = process.env.GITHUB_EVENT_PATH,
-    event = eventPath && require(eventPath),
-    isPR = process.env.GITHUB_EVENT_NAME?.includes('pull_request'),
+    event = eventPath && readJSON(eventPath)
+
+  const isPR = process.env.GITHUB_EVENT_NAME?.includes('pull_request'),
     defaultBranch = isPR
       ? (event?.pull_request?.head?.ref as string)
       : process.env.GITHUB_REF?.substring(11)
@@ -191,54 +222,162 @@ async function checkInputs() {
   if (getInput('add')) {
     const parsed = parseInputArray(getInput('add'))
     if (parsed.length == 1)
-      info('Add input parsed as single string, running 1 git add command.')
+      core.info('Add input parsed as single string, running 1 git add command.')
     else if (parsed.length > 1)
-      info(
+      core.info(
         `Add input parsed as string array, running ${parsed.length} git add commands.`
       )
-    else setFailed('Add input: array length < 1')
+    else core.setFailed('Add input: array length < 1')
   }
   if (getInput('remove')) {
-    const parsed = parseInputArray(getInput('remove'))
+    const parsed = parseInputArray(getInput('remove') || '')
     if (parsed.length == 1)
-      info('Remove input parsed as single string, running 1 git rm command.')
+      core.info(
+        'Remove input parsed as single string, running 1 git rm command.'
+      )
     else if (parsed.length > 1)
-      info(
+      core.info(
         `Remove input parsed as string array, running ${parsed.length} git rm commands.`
       )
-    else setFailed('Remove input: array length < 1')
+    else core.setFailed('Remove input: array length < 1')
   }
   // #endregion
 
+  // #region default_author
+  const default_author_valid = ['github_actor', 'user_info', 'github_actions']
+  if (!default_author_valid.includes(getInput('default_author')))
+    throw new Error(
+      `'${getInput(
+        'default_author'
+      )}' is not a valid value for default_author. Valid values: ${default_author_valid.join(
+        ', '
+      )}`
+    )
+  // #endregion
+
   // #region author_name, author_email
-  setDefault('author_name', `${process.env.GITHUB_ACTOR}`)
-  setDefault(
-    'author_email',
-    `${process.env.GITHUB_ACTOR}@users.noreply.github.com`
-  )
-  info(
+  let name, email
+  switch (getInput('default_author')) {
+    case 'github_actor': {
+      name = process.env.GITHUB_ACTOR
+      email = `${process.env.GITHUB_ACTOR}@users.noreply.github.com`
+      break
+    }
+
+    case 'user_info': {
+      if (!getInput('author_name') || !getInput('author_email')) {
+        const res = await getUserInfo(process.env.GITHUB_ACTOR)
+        if (!res?.name)
+          core.warning("Couldn't fetch author name, filling with github_actor.")
+        if (!res?.email)
+          core.warning(
+            "Couldn't fetch author email, filling with github_actor."
+          )
+
+        res?.name && (name = res?.name)
+        res?.email && (email = res.email)
+        if (name && email) break
+      }
+
+      !name && (name = process.env.GITHUB_ACTOR)
+      !email && (email = `${process.env.GITHUB_ACTOR}@users.noreply.github.com`)
+      break
+    }
+
+    case 'github_actions': {
+      name = 'github-actions'
+      email = '41898282+github-actions[bot]@users.noreply.github.com'
+      break
+    }
+
+    default:
+      throw new Error(
+        'This should not happen, please contact the author of this action. (checkInputs.author)'
+      )
+  }
+
+  setDefault('author_name', name)
+  setDefault('author_email', email)
+  core.info(
     `> Using '${getInput('author_name')} <${getInput(
       'author_email'
     )}>' as author.`
   )
   // #endregion
 
+  // #region committer_name, committer_email
+  if (getInput('committer_name') || getInput('committer_email'))
+    core.info(
+      `> Using custom committer info: ${
+        getInput('committer_name') ||
+        getInput('author_name') + ' [from author info]'
+      } <${
+        getInput('committer_email') ||
+        getInput('author_email') + ' [from author info]'
+      }>`
+    )
+
+  setDefault('committer_name', getInput('author_name'))
+  setDefault('committer_email', getInput('author_email'))
+  core.debug(
+    `Committer: ${getInput('committer_name')} <${getInput('committer_email')}>`
+  )
+  // #endregion
+
   // #region message
   setDefault(
     'message',
     `Commit from GitHub Actions (${process.env.GITHUB_WORKFLOW})`
   )
-  info(`> Using "${getInput('message')}" as commit message.`)
+  core.info(`> Using "${getInput('message')}" as commit message.`)
   // #endregion
 
   // #region branch
   const branch = setDefault('branch', defaultBranch || '')
-  if (isPR) info(`> Running for a PR, the action will use '${branch}' as ref.`)
+  if (isPR)
+    core.info(`> Running for a PR, the action will use '${branch}' as ref.`)
+  // #endregion
+
+  // #region pathspec_error_handling
+  const peh_valid = ['ignore', 'exitImmediately', 'exitAtEnd']
+  if (!peh_valid.includes(getInput('pathspec_error_handling')))
+    throw new Error(
+      `"${getInput(
+        'pathspec_error_handling'
+      )}" is not a valid value for the 'pathspec_error_handling' input. Valid values are: ${peh_valid.join(
+        ', '
+      )}`
+    )
+  // #endregion
+
+  // #region pull, pull_strategy [deprecated]
+  if (getInput('pull') && getInput('pull_strategy'))
+    throw new Error(
+      "You can't use both pull and pull_strategy as action inputs. Please remove pull_strategy, which is deprecated."
+    )
+
+  if ([getInput('pull'), getInput('pull_strategy')].includes('NO-PULL'))
+    core.debug("NO-PULL found: won't pull from remote.")
+  // #endregion
+
+  // #region push
+  if (getInput('push')) {
+    // It has to be either 'true', 'false', or any other string (use as arguments)
+    let value: string | boolean
+
+    try {
+      value = getInput('push', true)
+    } catch {
+      value = getInput('push')
+    }
+
+    core.debug(`Current push option: '${value}' (parsed as ${typeof value})`)
+  }
   // #endregion
 
   // #region signoff
   if (getInput('signoff')) {
-    const parsed = parseBool(getInput('signoff'))
+    const parsed = getInput('signoff', true)
 
     if (parsed === undefined)
       throw new Error(
@@ -249,7 +388,7 @@ async function checkInputs() {
 
     if (!parsed) setInput('signoff', undefined)
 
-    debug(
+    core.debug(
       `Current signoff option: ${getInput('signoff')} (${typeof getInput(
         'signoff'
       )})`
@@ -257,21 +396,17 @@ async function checkInputs() {
   }
   // #endregion
 
-  // #region push
-  if (getInput('push')) {
-    // It has to be either 'true', 'false', or any other string (use as arguments)
-    const parsed = parseBool(getInput('push'))
-
-    debug(
-      `Current push option: '${getInput('push')}' (parsed as ${typeof parsed})`
+  // #region github_token
+  if (!getInput('github_token'))
+    core.warning(
+      'No github_token has been detected, the action may fail if it needs to use the API'
     )
-  }
   // #endregion
 }
 
-async function add({ logWarning = true, ignoreErrors = false } = {}): Promise<
-  (void | Response<void>)[]
-> {
+async function add(
+  ignoreErrors: 'all' | 'pathspec' | 'none' = 'none'
+): Promise<(void | Response<void>)[]> {
   const input = getInput('add')
   if (!input) return []
 
@@ -283,18 +418,27 @@ async function add({ logWarning = true, ignoreErrors = false } = {}): Promise<
       // Push the result of every git command (which are executed in order) to the array
       // If any of them fails, the whole function will return a Promise rejection
       await git
-        .add(args.split(' '), (err: any, data?: any) =>
-          log(ignoreErrors ? null : err, data)
+        .add(matchGitArgs(args), (err: any, data?: any) =>
+          log(ignoreErrors == 'all' ? null : err, data)
         )
         .catch((e: Error) => {
-          if (ignoreErrors) return
+          // if I should ignore every error, return
+          if (ignoreErrors == 'all') return
+
+          // if it's a pathspec error...
           if (
             e.message.includes('fatal: pathspec') &&
-            e.message.includes('did not match any files') &&
-            logWarning
-          )
-            warning(`Add command did not match any file:\n  git add ${args}`)
-          else throw e
+            e.message.includes('did not match any files')
+          ) {
+            if (ignoreErrors == 'pathspec') return
+
+            const peh = getInput('pathspec_error_handling'),
+              err = new Error(
+                `Add command did not match any file: git add ${args}`
+              )
+            if (peh == 'exitImmediately') throw err
+            if (peh == 'exitAtEnd') exitErrors.push(err)
+          } else throw e
         })
     )
   }
@@ -302,10 +446,9 @@ async function add({ logWarning = true, ignoreErrors = false } = {}): Promise<
   return res
 }
 
-async function remove({
-  logWarning = true,
-  ignoreErrors = false
-} = {}): Promise<(void | Response<void>)[]> {
+async function remove(
+  ignoreErrors: 'all' | 'pathspec' | 'none' = 'none'
+): Promise<(void | Response<void>)[]> {
   const input = getInput('remove')
   if (!input) return []
 
@@ -317,20 +460,27 @@ async function remove({
       // Push the result of every git command (which are executed in order) to the array
       // If any of them fails, the whole function will return a Promise rejection
       await git
-        .rm(args.split(' '), (e: any, d?: any) =>
-          log(ignoreErrors ? null : e, d)
+        .rm(matchGitArgs(args), (e: any, d?: any) =>
+          log(ignoreErrors == 'all' ? null : e, d)
         )
         .catch((e: Error) => {
-          if (ignoreErrors) return
+          // if I should ignore every error, return
+          if (ignoreErrors == 'all') return
+
+          // if it's a pathspec error...
           if (
             e.message.includes('fatal: pathspec') &&
             e.message.includes('did not match any files')
-          )
-            logWarning &&
-              warning(
+          ) {
+            if (ignoreErrors == 'pathspec') return
+
+            const peh = getInput('pathspec_error_handling'),
+              err = new Error(
                 `Remove command did not match any file:\n  git rm ${args}`
               )
-          else throw e
+            if (peh == 'exitImmediately') throw err
+            if (peh == 'exitAtEnd') exitErrors.push(err)
+          } else throw e
         })
     )
   }
@@ -350,7 +500,7 @@ function parseInputArray(input: string): string[] {
       Array.isArray(json) &&
       json.every((e) => typeof e == 'string')
     ) {
-      debug(`Input parsed as JSON array of length ${json.length}`)
+      core.debug(`Input parsed as JSON array of length ${json.length}`)
       return json
     }
   } catch {}
@@ -362,19 +512,19 @@ function parseInputArray(input: string): string[] {
       Array.isArray(yaml) &&
       yaml.every((e) => typeof e == 'string')
     ) {
-      debug(`Input parsed as YAML array of length ${yaml.length}`)
+      core.debug(`Input parsed as YAML array of length ${yaml.length}`)
       return yaml
     }
   } catch {}
 
-  debug('Input parsed as single string')
+  core.debug('Input parsed as single string')
   return [input]
 }
 
 function logOutputs() {
-  startGroup('Outputs')
+  core.startGroup('Outputs')
   for (const key in outputs) {
-    info(`${key}: ${outputs[key]}`)
+    core.info(`${key}: ${outputs[key]}`)
   }
-  endGroup()
+  core.endGroup()
 }

src/util.ts

@@ -1,44 +1,142 @@
+import { parseArgsStringToArgv } from 'string-argv'
 import * as core from '@actions/core'
+import { Toolkit } from 'actions-toolkit'
+import fs from 'fs'
 
-export type Input =
-  | 'add'
-  | 'author_name'
-  | 'author_email'
-  | 'branch'
-  | 'cwd'
-  | 'message'
-  | 'pull_strategy'
-  | 'push'
-  | 'remove'
-  | 'signoff'
-  | 'tag'
+interface InputTypes {
+  add: string
+  author_name: string
+  author_email: string
+  branch: string
+  committer_name: string
+  committer_email: string
+  cwd: string
+  default_author: 'github_actor' | 'user_info' | 'github_actions'
+  message: string
+  pathspec_error_handling: 'ignore' | 'exitImmediately' | 'exitAtEnd'
+  pull: string | undefined
+  pull_strategy: string | undefined
+  push: string
+  remove: string | undefined
+  signoff: undefined
+  tag: string | undefined
 
-export const outputs = {
+  github_token: string | undefined
+}
+export type input = keyof InputTypes
+
+interface OutputTypes {
+  committed: 'true' | 'false'
+  commit_sha: string | undefined
+  pushed: 'true' | 'false'
+  tagged: 'true' | 'false'
+}
+export type output = keyof OutputTypes
+
+export const outputs: OutputTypes = {
   committed: 'false',
+  commit_sha: undefined,
   pushed: 'false',
   tagged: 'false'
 }
-export type Output = keyof typeof outputs
 
-export function getInput(name: Input) {
+type RecordOf<T extends string> = Record<T, string | undefined>
+export const tools = new Toolkit<RecordOf<input>, RecordOf<output>>({
+  secrets: [
+    'GITHUB_EVENT_PATH',
+    'GITHUB_EVENT_NAME',
+    'GITHUB_REF',
+    'GITHUB_ACTOR'
+  ]
+})
+
+export function getInput<T extends input>(name: T, parseAsBool: true): boolean
+export function getInput<T extends input>(
+  name: T,
+  parseAsBool?: false
+): InputTypes[T]
+export function getInput<T extends input>(
+  name: T,
+  parseAsBool = false
+): InputTypes[T] | boolean {
+  if (parseAsBool) return core.getBooleanInput(name)
+  // @ts-expect-error
   return core.getInput(name)
 }
 
+export async function getUserInfo(username?: string) {
+  if (!username) return undefined
+
+  const res = await tools.github.users.getByUsername({ username })
+
+  core.debug(
+    `Fetched github actor from the API: ${JSON.stringify(res?.data, null, 2)}`
+  )
+
+  return {
+    name: res?.data?.name,
+    email: res?.data?.email
+  }
+}
+
 export function log(err: any | Error, data?: any) {
   if (data) console.log(data)
   if (err) core.error(err)
 }
 
-export function parseBool(value: any) {
-  try {
-    const parsed = JSON.parse(value)
-    if (typeof parsed == 'boolean') return parsed
-  } catch {}
+/**
+ * Matches the given string to an array of arguments.  
+ * The parsing is made by `string-argv`: if your way of using argument is not supported, the issue is theirs!
+ * {@link https://www.npm.im/string-argv}
+ * @example
+ * ```js
+ * matchGitArgs(`
+    -s
+    --longOption 'This uses the "other" quotes'
+    --foo 1234
+    --file=message.txt
+    --file2="Application 'Support'/\"message\".txt"
+  `) => [
+    '-s',
+    '--longOption',
+    'This uses the "other" quotes',
+    '--foo',
+    '1234',
+    '--file=message.txt',
+    `--file2="Application 'Support'/\\"message\\".txt"`
+  ]
+ * matchGitArgs('      ') => [ ]
+ * ```
+ * @returns An array, if there's no match it'll be empty
+ */
+export function matchGitArgs(string: string) {
+  const parsed = parseArgsStringToArgv(string)
+  core.debug(`Git args parsed:
+  - Original: ${string}
+  - Parsed: ${JSON.stringify(parsed)}`)
+  return parsed
 }
 
-export function setOutput(name: Output, value: 'true' | 'false') {
+export function readJSON(filePath: string) {
+  let fileContent: string
+  try {
+    fileContent = fs.readFileSync(filePath, { encoding: 'utf8' })
+  } catch {
+    throw `Couldn't read file. File path: ${filePath}`
+  }
+
+  try {
+    return JSON.parse(fileContent)
+  } catch {
+    throw `Couldn't parse file to JSON. File path: ${filePath}`
+  }
+}
+
+export function setOutput<T extends output>(name: T, value: OutputTypes[T]) {
   core.debug(`Setting output: ${name}=${value}`)
   outputs[name] = value
-  return core.setOutput(name, value)
+  core.setOutput(name, value)
 }
-for (const key in outputs) setOutput(key as Output, outputs[key])
+
+// Setup default output values
+Object.entries(outputs).forEach(([name, value]) => core.setOutput(name, value))

tsconfig.json

@@ -35,7 +35,7 @@
     // "noImplicitReturns": true,             /* Report error when not all code paths in function return a value. */
     // "noFallthroughCasesInSwitch": true,    /* Report errors for fallthrough cases in switch statement. */
     /* Module Resolution Options */
-    // "moduleResolution": "node",            /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
+    "moduleResolution": "node",            /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
     // "baseUrl": "./",                       /* Base directory to resolve non-absolute module names. */
     // "paths": {},                           /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
     // "rootDirs": [],                        /* List of root folders whose combined content represents the structure of the project at runtime. */